Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49638][SQL] Remove the ANSI config suggestion in INVALID_URL #48616

Closed
wants to merge 10 commits into from
Closed

[SPARK-49638][SQL] Remove the ANSI config suggestion in INVALID_URL #48616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4656fbd
Add try_parse_url expression
jovanm-db Oct 16, 2024
fbc201b
Fix errors
jovanm-db Oct 16, 2024
f49745a
Fix formatting
jovanm-db Oct 16, 2024
5793bff
Fix formatting
jovanm-db Oct 16, 2024
3122ac6
Add tests
jovanm-db Oct 17, 2024
a2a1e8c
Fix test and formatting
jovanm-db Oct 17, 2024
5071226
Revert changes and split tasks into a new ticket
jovanm-db Oct 18, 2024
7c2ab44
Improve error message for ParseUrl
jovanm-db Oct 18, 2024
a866fca
Merge branch 'master' into improvedError
jovanm-db Oct 23, 2024
66634bc
Fix merge error
jovanm-db Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3230,7 +3230,7 @@
},
"INVALID_URL" : {
"message" : [
"The url is invalid: <url>. If necessary set <ansiConfig> to \"false\" to bypass this error."
"The url is invalid: <url>. Use `try_parse_url` to tolerate invalid URL and return NULL instead."
],
"sqlState" : "22P02"
},
Expand Down
4 changes: 1 addition & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
def invalidUrlError(url: UTF8String, e: URISyntaxException): SparkIllegalArgumentException = {
new SparkIllegalArgumentException(
errorClass = "INVALID_URL",
messageParameters = Map(
"url" -> url.toString,
"ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)),
messageParameters = Map("url" -> url.toString),
cause = e)
}

Expand Down
6 changes: 1 addition & 5 deletions sql/core/src/test/scala/org/apache/spark/sql/UrlFunctionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package org.apache.spark.sql

import org.apache.spark.SparkIllegalArgumentException
import org.apache.spark.sql.catalyst.util.TypeUtils.toSQLConf
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SharedSparkSession

Expand Down Expand Up @@ -77,10 +76,7 @@ class UrlFunctionsSuite extends QueryTest with SharedSparkSession {
sql(s"SELECT parse_url('$url', 'HOST')").collect()
},
condition = "INVALID_URL",
parameters = Map(
"url" -> url,
"ansiConfig" -> toSQLConf(SQLConf.ANSI_ENABLED.key)
))
parameters = Map("url" -> url))
}
}

Expand Down