Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6074] [sql] Package pyspark sql bindings. #4822

Closed
wants to merge 1 commit into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Feb 28, 2015

This is needed for the SQL bindings to work on Yarn.

This is needed for the SQL bindings to work on Yarn.
@vanzin
Copy link
Contributor Author

vanzin commented Feb 28, 2015

$ jar tf sql/core/target/spark-sql_2.10-1.3.0-SNAPSHOT.jar | grep pyspark
pyspark/
pyspark/sql/
pyspark/sql/functions.py
pyspark/sql/__init__.py
pyspark/sql/tests.py
pyspark/sql/types.py
pyspark/sql/dataframe.py
pyspark/sql/context.py

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #28106 has started for PR 4822 at commit fb52001.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Feb 28, 2015

That seems like the right way to do this thing. It mirrors similar declarations for core, mllib, streaming, etc. Should tests.py be in here? Maybe not worth bothering since other declarations don't exclude test .py files.

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #28106 has finished for PR 4822 at commit fb52001.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28106/
Test PASSed.

@srowen
Copy link
Member

srowen commented Feb 28, 2015

I'd like to merge this in the next day or two as I think I agree that this could be a blocker. I think it's straightforward but invite a third set of eyes to take a look.

@pwendell
Copy link
Contributor

pwendell commented Mar 1, 2015

Good catch @vanzin. This LGTM. I did some testing to verify that the assembly includes all relevant python files now:

$ jar -tf assembly/target/scala-2.10/spark-assembly-1.3.0-SNAPSHOT-hadoop1.0.4.jar  |grep \\.py$ |grep pyspark  | wc
      62      62    1480
$ find ./python/pyspark/ | grep \\.py$ | wc
      62      62    2100

asfgit pushed a commit that referenced this pull request Mar 1, 2015
This is needed for the SQL bindings to work on Yarn.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #4822 from vanzin/SPARK-6074 and squashes the following commits:

fb52001 [Marcelo Vanzin] [SPARK-6074] [sql] Package pyspark sql bindings.

(cherry picked from commit fd8d283)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in fd8d283 Mar 1, 2015
@vanzin vanzin deleted the SPARK-6074 branch March 2, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants