Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6070] [yarn] Remove unneeded classes from shuffle service jar. #4820

Closed
wants to merge 3 commits into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Feb 27, 2015

These may conflict with the classes already in the NM. We shouldn't
be repackaging them.

These may conflict with the classes already in the NM. We shouldn't
be repackaging them.
@vanzin
Copy link
Contributor Author

vanzin commented Feb 27, 2015

I re-generated the jar with this patch and verified there are no "org.apache.hadoop" classes in it.

@vanzin
Copy link
Contributor Author

vanzin commented Feb 27, 2015

Also, an alternative solution would be to force the "hadoop-provided" profile to always be on in this module. Should have the same end result.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28097 has started for PR 4820 at commit 7a18a1b.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

Thanks for finding this! Either approach seems fine to me. This LGTM... it might be nice to add a comment explaining that this is needed because the root pom is declaring them at compile scope.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28099 has started for PR 4820 at commit 3cba946.

  • This patch merges cleanly.

@vanzin
Copy link
Contributor Author

vanzin commented Feb 27, 2015

I updated the diff with the profile approach since it doesn't requiring looking for what dependencies have their scope overridden, and seems cleaner overall.

@vanzin
Copy link
Contributor Author

vanzin commented Feb 27, 2015

Actually, d'oh, there might be an even easier fix. Hang on.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28100 has started for PR 4820 at commit 871b566.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

Cool LGTM

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #28097 has finished for PR 4820 at commit 7a18a1b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28097/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #28099 has finished for PR 4820 at commit 3cba946.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28099/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #28100 has finished for PR 4820 at commit 871b566.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28100/
Test PASSed.

@pwendell
Copy link
Contributor

Thanks Marcelo, pulling this in!

asfgit pushed a commit that referenced this pull request Feb 28, 2015
These may conflict with the classes already in the NM. We shouldn't
be repackaging them.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #4820 from vanzin/SPARK-6070 and squashes the following commits:

871b566 [Marcelo Vanzin] The "d'oh how didn't I think of it before" solution.
3cba946 [Marcelo Vanzin] Use profile instead, so that dependencies don't need to be explicitly listed.
7a18a1b [Marcelo Vanzin] [SPARK-6070] [yarn] Remove unneeded classes from shuffle service jar.

(cherry picked from commit dba08d1)
Signed-off-by: Patrick Wendell <patrick@databricks.com>
@asfgit asfgit closed this in dba08d1 Feb 28, 2015
@vanzin vanzin deleted the SPARK-6070 branch March 2, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants