-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-6070] [yarn] Remove unneeded classes from shuffle service jar. #4820
Conversation
These may conflict with the classes already in the NM. We shouldn't be repackaging them.
I re-generated the jar with this patch and verified there are no "org.apache.hadoop" classes in it. |
Also, an alternative solution would be to force the "hadoop-provided" profile to always be on in this module. Should have the same end result. |
Test build #28097 has started for PR 4820 at commit
|
Thanks for finding this! Either approach seems fine to me. This LGTM... it might be nice to add a comment explaining that this is needed because the root pom is declaring them at compile scope. |
Test build #28099 has started for PR 4820 at commit
|
I updated the diff with the profile approach since it doesn't requiring looking for what dependencies have their scope overridden, and seems cleaner overall. |
Actually, d'oh, there might be an even easier fix. Hang on. |
Test build #28100 has started for PR 4820 at commit
|
Cool LGTM |
Test build #28097 has finished for PR 4820 at commit
|
Test PASSed. |
Test build #28099 has finished for PR 4820 at commit
|
Test PASSed. |
Test build #28100 has finished for PR 4820 at commit
|
Test PASSed. |
Thanks Marcelo, pulling this in! |
These may conflict with the classes already in the NM. We shouldn't be repackaging them. Author: Marcelo Vanzin <vanzin@cloudera.com> Closes #4820 from vanzin/SPARK-6070 and squashes the following commits: 871b566 [Marcelo Vanzin] The "d'oh how didn't I think of it before" solution. 3cba946 [Marcelo Vanzin] Use profile instead, so that dependencies don't need to be explicitly listed. 7a18a1b [Marcelo Vanzin] [SPARK-6070] [yarn] Remove unneeded classes from shuffle service jar. (cherry picked from commit dba08d1) Signed-off-by: Patrick Wendell <patrick@databricks.com>
These may conflict with the classes already in the NM. We shouldn't
be repackaging them.