[SPARK-49569][CONNECT][SQL] Add shims to support SparkContext and RDD #48065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Sep 10, 2024
| @@ -52,4 +52,7 @@ package object sql { | |||
| f(builder) | |||
| column(builder.build()) | |||
| } | |||
|
|
|||
| private[sql] def throwRddNotSupportedException(): Nothing = | |||
| throw new UnsupportedOperationException("RDDs are not supported in Spark Connect.") | |||
There was a problem hiding this comment.
Make this use the error framework.
hvanhovell
commented
Sep 10, 2024
| client.hijackServerSideSessionIdForTesting(suffix) | ||
| } | ||
|
|
||
| /** @inheritdoc */ | ||
| override def sparkContext: SparkContext = |
There was a problem hiding this comment.
Make this use the error framework.
HyukjinKwon
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Could you make CIs happy, @hvanhovell ?
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala:83:18: value aggregate is not a member of org.apache.spark.rdd.RDD[Array[String]]
[error] tokenRDD.aggregate(startType)(inferRowType, mergeRowTypes)
|
@dongjoon-hyun yeah working on it. SBT does not seem to respect maven exclusions... |
|
Could you rebase once more, @hvanhovell ? |
|
@dongjoon-hyun it is a bit more complicated. While SBT compile seems to respect Maven exclusions, test:compile and package do not. Investigating. I'd personally not hold off preview2 because of this. |
|
Ack! Thank you for sharing the status, @hvanhovell . |
|
Could you re-trigger the failed CIs? |
|
Merging to master. |
|
This PR has caused the Maven daily test build to fail: xxx.
I am trying to fix it at: #48399 |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? This PR does two things: - It adds shims for SparkContext and RDD. These are in a separate module. This module is a compile time dependency for sql/api, and a regular dependency for connector/connect/client/jvm. We remove this dependency in catalyst and connect-server because those should use the actual implementation. - It adds RDD (and the one SparkContext) based method to the shared Scala API. For connect these methods throw an unsupported operation exception. ### Why are the changes needed? We are creating a shared Scala interface for Classic and Connect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. I will add a couple on the connect side. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48065 from hvanhovell/SPARK-49569. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR does two things:
Why are the changes needed?
We are creating a shared Scala interface for Classic and Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests. I will add a couple on the connect side.
Was this patch authored or co-authored using generative AI tooling?
No.