-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48493][PYTHON][FOLLOW-UP] Fix documentation for Arrow batch support in Python Data Source #48001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@allisonwang-db fyi |
yaooqinn
approved these changes
Sep 5, 2024
dongjoon-hyun
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…pport in Python Data Source ### What changes were proposed in this pull request? This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at: ```diff - Python Datasource Reader with direct Arrow Batch support for improved performance - ----------------------------------------------------------------------------------------- + Python Data Source Reader with direct Arrow Batch support for improved performance + ---------------------------------------------------------------------------------- ``` ### Why are the changes needed? Otherwise, Sphinx documentation build complains with warnings. ### Does this PR introduce _any_ user-facing change? It fixes some typos in user-facing documentation. ### How was this patch tested? Manually built the documentation ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48001 from HyukjinKwon/SPARK-48493-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…pport in Python Data Source ### What changes were proposed in this pull request? This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at: ```diff - Python Datasource Reader with direct Arrow Batch support for improved performance - ----------------------------------------------------------------------------------------- + Python Data Source Reader with direct Arrow Batch support for improved performance + ---------------------------------------------------------------------------------- ``` ### Why are the changes needed? Otherwise, Sphinx documentation build complains with warnings. ### Does this PR introduce _any_ user-facing change? It fixes some typos in user-facing documentation. ### How was this patch tested? Manually built the documentation ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48001 from HyukjinKwon/SPARK-48493-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…pport in Python Data Source ### What changes were proposed in this pull request? This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at: ```diff - Python Datasource Reader with direct Arrow Batch support for improved performance - ----------------------------------------------------------------------------------------- + Python Data Source Reader with direct Arrow Batch support for improved performance + ---------------------------------------------------------------------------------- ``` ### Why are the changes needed? Otherwise, Sphinx documentation build complains with warnings. ### Does this PR introduce _any_ user-facing change? It fixes some typos in user-facing documentation. ### How was this patch tested? Manually built the documentation ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48001 from HyukjinKwon/SPARK-48493-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #46826 that mainly fixes documentation. The real main thing is to match the length of the title at:
Why are the changes needed?
Otherwise, Sphinx documentation build complains with warnings.
Does this PR introduce any user-facing change?
It fixes some typos in user-facing documentation.
How was this patch tested?
Manually built the documentation
Was this patch authored or co-authored using generative AI tooling?
No.