Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48493][PYTHON][FOLLOW-UP] Fix documentation for Arrow batch support in Python Data Source #48001

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #46826 that mainly fixes documentation. The real main thing is to match the length of the title at:

- Python Datasource Reader with direct Arrow Batch support for improved performance
- -----------------------------------------------------------------------------------------
+ Python Data Source Reader with direct Arrow Batch support for improved performance
+ ----------------------------------------------------------------------------------

Why are the changes needed?

Otherwise, Sphinx documentation build complains with warnings.

Does this PR introduce any user-facing change?

It fixes some typos in user-facing documentation.

How was this patch tested?

Manually built the documentation

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member Author

@allisonwang-db fyi

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master.

Copy link
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

IvanK-db pushed a commit to IvanK-db/spark that referenced this pull request Sep 20, 2024
…pport in Python Data Source

### What changes were proposed in this pull request?

This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at:

```diff
- Python Datasource Reader with direct Arrow Batch support for improved performance
- -----------------------------------------------------------------------------------------
+ Python Data Source Reader with direct Arrow Batch support for improved performance
+ ----------------------------------------------------------------------------------
```

### Why are the changes needed?

Otherwise, Sphinx documentation build complains with warnings.

### Does this PR introduce _any_ user-facing change?

It fixes some typos in user-facing documentation.

### How was this patch tested?

Manually built the documentation

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48001 from HyukjinKwon/SPARK-48493-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…pport in Python Data Source

### What changes were proposed in this pull request?

This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at:

```diff
- Python Datasource Reader with direct Arrow Batch support for improved performance
- -----------------------------------------------------------------------------------------
+ Python Data Source Reader with direct Arrow Batch support for improved performance
+ ----------------------------------------------------------------------------------
```

### Why are the changes needed?

Otherwise, Sphinx documentation build complains with warnings.

### Does this PR introduce _any_ user-facing change?

It fixes some typos in user-facing documentation.

### How was this patch tested?

Manually built the documentation

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48001 from HyukjinKwon/SPARK-48493-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
…pport in Python Data Source

### What changes were proposed in this pull request?

This PR is a followup of apache#46826 that mainly fixes documentation. The real main thing is to match the length of the title at:

```diff
- Python Datasource Reader with direct Arrow Batch support for improved performance
- -----------------------------------------------------------------------------------------
+ Python Data Source Reader with direct Arrow Batch support for improved performance
+ ----------------------------------------------------------------------------------
```

### Why are the changes needed?

Otherwise, Sphinx documentation build complains with warnings.

### Does this PR introduce _any_ user-facing change?

It fixes some typos in user-facing documentation.

### How was this patch tested?

Manually built the documentation

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#48001 from HyukjinKwon/SPARK-48493-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants