[SPARK-49284][CONNECT][SQL] Create a shared Catalog interface #47991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Sep 5, 2024
|
LGTM thank you! btw ClientStreamingQuerySuite and FlatMapGroupsWithStateStreamingSuite seem flaky and also fail in my PR. |
xinrong-meng
approved these changes
Sep 5, 2024
|
@HyukjinKwon Have there been any major changes to the startup process of the connect-server recently? I've noticed that it has frequently failed to start during recent GA tests, such as the current pr: 
and other cases:
and daily tests and master pipline: |
|
Yeah, #47994 should fix it |
HyukjinKwon
force-pushed
the
SPARK-49284
branch
from
55e75b3
to
5491570
Compare
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR creates a shared Catalog interface. We also move the interfaces to sql/api.
Why are the changes needed?
We are creating a shared Scala Spark SQL interface for Classic and Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.