[SPARK-49498][SQL] Added test to check difference between SR_AI and SR_Latn_AI collations #47958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankandic
reviewed
Sep 2, 2024
| @@ -33,7 +35,7 @@ import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper | |||
| import org.apache.spark.sql.execution.aggregate.{HashAggregateExec, ObjectHashAggregateExec} | |||
| import org.apache.spark.sql.execution.columnar.InMemoryTableScanExec | |||
| import org.apache.spark.sql.execution.joins._ | |||
| import org.apache.spark.sql.internal.{SqlApiConf, SQLConf} | |||
| import org.apache.spark.sql.internal.{SQLConf, SqlApiConf} | |||
| // scalastyle:off nonascii | ||
| // SR_AI collation | ||
| var collationName = "SR_AI" | ||
| var builder = new ULocale.Builder(); |
There was a problem hiding this comment.
We should still test spark's and not directly the ICU behavior, even though we use ICU under the hood
| builder.setUnicodeLocaleKeyword("kc", "true") | ||
| collator = Collator.getInstance(builder.build()) | ||
|
|
||
| assert(collator.compare("c", "ć") != 0) |
There was a problem hiding this comment.
we can probably put this inside a loop to avoid repetitive calls
|
Mind filing a JIRA please? See also https://spark.apache.org/contributing.html |
ilicmarkodb
changed the title
ilicmarkodb
force-pushed
the
add_test_for_difference_between_SR_AI_and_SR_Latn_AI_collations
branch
from
cffc0a3
to
ab0c6a5
Compare
|
@cloud-fan can you please review? |
stefankandic
reviewed
Sep 9, 2024
| ("Z", "Ž") | ||
| ).foreach { | ||
| case (c1, c2) => | ||
| checkAnswer(sql(s"SELECT '$c1' = '$c2' COLLATE SR_Latn_AI"), Row(false)) |
There was a problem hiding this comment.
can we also check the result for sr_ai here? It's more readable than comparing multiple characters at a time like you did above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added test to check difference between SR_AI and SR_Latn_AI collations.
Why are the changes needed?
Better testing.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test added to
CollationSuite.scalaWas this patch authored or co-authored using generative AI tooling?
No.