Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5994] [SQL] Python DataFrame documentation fixes #4756

Closed
wants to merge 2 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Feb 25, 2015

select empty should NOT be the same as select. make sure selectExpr is behaving the same.
join param documentation
link to source doesn't work in jekyll generated file
cross reference of columns (i.e. enabling linking)
show(): move df example before df.show()
move tests in SQLContext out of docstring otherwise doc is too long
Column.desc and .asc doesn't have any documentation
in documentation, sort functions.*)

@davies
Copy link
Contributor Author

davies commented Feb 25, 2015

cc @rxin

@SparkQA
Copy link

SparkQA commented Feb 25, 2015

Test build #27929 has started for PR 4756 at commit f30502c.

  • This patch merges cleanly.

@@ -69,6 +69,7 @@ def _(col):
globals()[_name] = _create_function(_name, _doc)
del _name, _doc
__all__ += _functions.keys()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a line of comment to all to say that _functions are automatically added to the list.

@SparkQA
Copy link

SparkQA commented Feb 25, 2015

Test build #27929 has finished for PR 4756 at commit f30502c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27929/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Feb 25, 2015

lgtm

asfgit pushed a commit that referenced this pull request Feb 25, 2015
select empty should NOT be the same as select. make sure selectExpr is behaving the same.
join param documentation
link to source doesn't work in jekyll generated file
cross reference of columns (i.e. enabling linking)
show(): move df example before df.show()
move tests in SQLContext out of docstring otherwise doc is too long
Column.desc and .asc doesn't have any documentation
in documentation, sort functions.*)

Author: Davies Liu <davies@databricks.com>

Closes #4756 from davies/df_docs and squashes the following commits:

f30502c [Davies Liu] fix doc
32f0d46 [Davies Liu] fix DataFrame docs

(cherry picked from commit d641fbb)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

Thanks! Merged to master and branch 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants