Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48543][SS] Track state row validation failures using explicit error class #46885

Closed
wants to merge 7 commits into from

Conversation

anishshri-db
Copy link
Contributor

@anishshri-db anishshri-db commented Jun 5, 2024

What changes were proposed in this pull request?

Track state row validation failures using explicit error class

Why are the changes needed?

We want to track these exceptions explicitly since they could be indicative of underlying corruptions/data loss scenarios.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing unit tests

13:06:32.803 INFO org.apache.spark.util.ShutdownHookManager: Deleting directory /Users/anish.shrigondekar/spark/spark/target/tmp/spark-6d90d3f3-0f37-48b8-8506-a8cdee3d25d7
[info] Run completed in 9 seconds, 861 milliseconds.
[info] Total number of tests run: 4
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 4, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Was this patch authored or co-authored using generative AI tooling?

No

@anishshri-db
Copy link
Contributor Author

cc - @HeartSaVioR - PTAL, thx !

@anishshri-db anishshri-db changed the title [SPARK-48543] Track state row validation failures using explicit error class [SPARK-48543][SS] Track state row validation failures using explicit error class Jun 5, 2024
@anishshri-db
Copy link
Contributor Author

Tests are all passing. Not sure why the page is not updated.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@HeartSaVioR
Copy link
Contributor

Wait... @anishshri-db if we consider this as worth monitoring, is it sufficient that we categorize this as internal class with state store? Wouldn't we like to give an explicit error class instead?

@anishshri-db
Copy link
Contributor Author

@HeartSaVioR - PTAL now, thx !

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor. Thanks for making change!

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending CI

@HeartSaVioR
Copy link
Contributor

Thanks! Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants