[SPARK-47900] Fix check for implicit (UTF8_BINARY) collation #46116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankandic
changed the title
cloud-fan
approved these changes
Apr 19, 2024
|
@cloud-fan can we merge this? |
|
thanks, merging to master! |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Fix method name and logic for cases where we want to check if the string has the UTF8 binary (implicit) collation. ### Why are the changes needed? apache#45592 introduced session level collation which meant that the concept of default collation is not the same as the implicit collation. Method in `SchemaUtils` had its name and logic changed to mean that the collation is binary orderable but that was not it's original intent. It should check if the collation is not implicit/UTF8 binary (`id != 0`). ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46116 from stefankandic/fixBinaryCheckLogic. Authored-by: Stefan Kandic <stefan.kandic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix method name and logic for cases where we want to check if the string has the UTF8 binary (implicit) collation.
Why are the changes needed?
#45592 introduced session level collation which meant that the concept of default collation is not the same as the implicit collation. Method in
SchemaUtilshad its name and logic changed to mean that the collation is binary orderable but that was not it's original intent. It should check if the collation is not implicit/UTF8 binary (id != 0).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No