[SPARK-44746][PYTHON] Add more Python UDTF documentation for functions that accept input tables #45375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtenedor
commented
Mar 5, 2024
There was a problem hiding this comment.
Thanks @allisonwang-db for your review! Responded to your comments.
allisonwang-db
approved these changes
Mar 5, 2024
| spark.sql("CREATE TABLE values_table (a STRING, b INT)") | ||
| spark.sql("INSERT INTO values_table VALUES ('abc', 2), ('abc', 4), ('def', 6), ('def', 8)") | ||
| spark.table("values_table").show() | ||
|
|
There was a problem hiding this comment.
maybe we can have the output of the show() here?
There was a problem hiding this comment.
Sure, this is done.
|
Looks good! Also cc @ueshin and @HyukjinKwon |
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
Mar 6, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds more Python UDTF documentation for functions that accept input tables.
Why are the changes needed?
This functionality was added recently but not covered in docs yet.
Does this PR introduce any user-facing change?
No, it's a documentation-only change.
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No