Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL][Minor] correct some comments #4508

Closed
wants to merge 2 commits into from
Closed

[SQL][Minor] correct some comments #4508

wants to merge 2 commits into from

Conversation

OopsOutOfMemory
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Feb 10, 2015

ok to test

@srowen
Copy link
Member

srowen commented Feb 10, 2015

(heh, do we even need Jenkins to test comment-only changes like this?)
Yes, very minor, but looks correct on comparing it to the code in DescribeCommand below.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27214 has started for PR 4508 at commit f24aeaf.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 10, 2015

Test build #27214 has finished for PR 4508 at commit f24aeaf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27214/
Test PASSed.

srowen
srowen reviewed Feb 10, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala
@@ -291,7 +291,7 @@ private[sql] case class ResolvedDataSource(provider: Class[_], relation: BaseRel
* Returned for the "DESCRIBE [EXTENDED] [dbName.]tableName" command.
* @param table The table to be described.
* @param isExtended True if "DESCRIBE EXTENDED" is used. Otherwise, false.
* It is effective only when the table is a Hive table.
* It is effective only when the table is a Hive table.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to nit-pick on a trivial change, but please undo this indentation change. From what I see in the rest of the code's scaladoc, continuations are aligned as it was, not wrapped all the way to the left. Have a look at RDD.scala for a lot of examples.

@OopsOutOfMemory
Update ddl.scala
d8a68c6 
undo intend
@OopsOutOfMemory
Copy link
Contributor Author

Thanks @srowen : )

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27250 has started for PR 4508 at commit d8a68c6.

  • This patch merges cleanly.

@asfgit asfgit closed this in 91e3512 Feb 11, 2015
@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27250 has finished for PR 4508 at commit d8a68c6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27250/
Test PASSed.

@OopsOutOfMemory OopsOutOfMemory deleted the cmt branch February 11, 2015 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OopsOutOfMemory @AmplabJenkins @srowen @SparkQA