[SPARK-5714][Mllib] Refactor initial step of LDA to remove redundant operations #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #27193 has finished for PR 4501 at commit
|
|
an unrelated failure... |
|
cc @jkbradley. |
| partEdges.flatMap { edge => | ||
| val gamma = normalize(BDV.fill[Double](k)(random.nextDouble()), 1.0) | ||
| val sum = BDV.zeros[Double](k) | ||
| brzAxpy(edge.attr, gamma, sum) |
There was a problem hiding this comment.
This is val sum = gamma * edge.attr. We don't need axpy if the target vector does not exist.
|
Test build #27268 has finished for PR 4501 at commit
|
|
LGTM. Merged into master and branch-1.3. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2015
…operations The `initialState` of LDA performs several RDD operations that looks redundant. This pr tries to simplify these operations. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes #4501 from viirya/sim_lda and squashes the following commits: 4870fe4 [Liang-Chi Hsieh] For comments. 9af1487 [Liang-Chi Hsieh] Refactor initial step of LDA to remove redundant operations. (cherry picked from commit f86a89a) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
initialStateof LDA performs several RDD operations that looks redundant. This pr tries to simplify these operations.