[SPARK-45111][BUILD] Upgrade maven to 3.9.4 #42827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, is it good, @LuciferYang ? |
|
LGTM |
LuciferYang
changed the title
|
Seems this version is okay, but let me run more tests just to be sure. @dongjoon-hyun @srowen |
LuciferYang
force-pushed
the
maven-394
branch
from
2c848b5
to
9f52e5a
Compare
|
I think this one is ready to go |
|
Merged to master |
There was a problem hiding this comment.
BTW, for the record, Maven has been working with Java 21-ea already.
The JIRA mentioned in this PR is about adding Java 20 to GitHub Action Java matrix and to adjust their test code, TestRepositoryConnector.java. Given that, there was no actual issues to the Java 20+ users.
|
Thanks @srowen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
The new version lift JDK minimum to JDK 8 and make the build work on JDK 20 . It also brings a series of bug fixes, such as Fix deadlock during forked lifecycle executions, along with a number of new optimizations like Profile activation by packaging. On the other hand, the new version replaces 'Wagon' with 'native http' as the new Maven Resolver transport, coupled with a range of targeted performance enhancements（See the upgrades related to Maven Resolver）.
For other updates, refer to the corresponding release notes:
Does this PR introduce any user-facing change?
No
How was this patch tested?
run
build/mvn -versionwll trigger downloadapache-maven-3.9.4-bin.tar.gzWas this patch authored or co-authored using generative AI tooling?
No