-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-45111][BUILD] Upgrade maven to 3.9.4 #42827
Conversation
So, is it good, @LuciferYang ? |
LGTM |
Seems this version is okay, but let me run more tests just to be sure. @dongjoon-hyun @srowen |
2c848b5
to
9f52e5a
Compare
I think this one is ready to go |
Merged to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, for the record, Maven has been working with Java 21-ea already.
The JIRA mentioned in this PR is about adding Java 20 to GitHub Action Java matrix and to adjust their test code, TestRepositoryConnector.java
. Given that, there was no actual issues to the Java 20+ users.
Thanks @srowen |
What changes were proposed in this pull request?
Why are the changes needed?
The new version lift JDK minimum to JDK 8 and make the build work on JDK 20 . It also brings a series of bug fixes, such as Fix deadlock during forked lifecycle executions, along with a number of new optimizations like Profile activation by packaging. On the other hand, the new version replaces 'Wagon' with 'native http' as the new Maven Resolver transport, coupled with a range of targeted performance enhancements(See the upgrades related to Maven Resolver).
For other updates, refer to the corresponding release notes:
Does this PR introduce any user-facing change?
No
How was this patch tested?
run
build/mvn -version
wll trigger downloadapache-maven-3.9.4-bin.tar.gz
Was this patch authored or co-authored using generative AI tooling?
No