Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43780][SQL][FOLLOWUP] Fix the config doc spark.sql.optimizer.decorrelateJoinPredicate.enabled #42607

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Aug 22, 2023

What changes were proposed in this pull request?

Add s" to the doc of the SQL config spark.sql.optimizer.decorrelateJoinPredicate.enabled.

Why are the changes needed?

To output the desired config name.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running CI.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxGekk
Copy link
Member Author

MaxGekk commented Aug 22, 2023

Merging to master. Thank you, @yaooqinn @cloud-fan @Hisoka-X for review.

@MaxGekk MaxGekk closed this in 24293ca Aug 22, 2023
Copy link
Contributor

@allisonwang-db allisonwang-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

valentinp17 pushed a commit to valentinp17/spark that referenced this pull request Aug 24, 2023
…decorrelateJoinPredicate.enabled`

### What changes were proposed in this pull request?
Add s" to the doc of the SQL config `spark.sql.optimizer.decorrelateJoinPredicate.enabled`.

### Why are the changes needed?
To output the desired config name.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By running CI.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#42607 from MaxGekk/followup-agubichev_spark-43780-corr-predicate.

Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
ragnarok56 pushed a commit to ragnarok56/spark that referenced this pull request Mar 2, 2024
…decorrelateJoinPredicate.enabled`

### What changes were proposed in this pull request?
Add s" to the doc of the SQL config `spark.sql.optimizer.decorrelateJoinPredicate.enabled`.

### Why are the changes needed?
To output the desired config name.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By running CI.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#42607 from MaxGekk/followup-agubichev_spark-43780-corr-predicate.

Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants