[SPARK-43709][PS] Remove closed parameter from ps.date_range & enable test.
#42389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Aug 9, 2023
|
Merged to master. |
hvanhovell
pushed a commit
to hvanhovell/spark
that referenced
this pull request
Aug 13, 2023
…able test ### What changes were proposed in this pull request? This PR proposes to remove `closed` parameter from `ps.date_range` & enable test. See pandas-dev/pandas#40245 more detail. ### Why are the changes needed? To support pandas 2.0.0 and above. ### Does this PR introduce _any_ user-facing change? `closed` parameter will no longer available from `ps.date_range` API. ### How was this patch tested? Enabling the existing UT. Closes apache#42389 from itholic/closed_removing. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
valentinp17
pushed a commit
to valentinp17/spark
that referenced
this pull request
Aug 24, 2023
…able test ### What changes were proposed in this pull request? This PR proposes to remove `closed` parameter from `ps.date_range` & enable test. See pandas-dev/pandas#40245 more detail. ### Why are the changes needed? To support pandas 2.0.0 and above. ### Does this PR introduce _any_ user-facing change? `closed` parameter will no longer available from `ps.date_range` API. ### How was this patch tested? Enabling the existing UT. Closes apache#42389 from itholic/closed_removing. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
ragnarok56
pushed a commit
to ragnarok56/spark
that referenced
this pull request
Mar 2, 2024
…able test ### What changes were proposed in this pull request? This PR proposes to remove `closed` parameter from `ps.date_range` & enable test. See pandas-dev/pandas#40245 more detail. ### Why are the changes needed? To support pandas 2.0.0 and above. ### Does this PR introduce _any_ user-facing change? `closed` parameter will no longer available from `ps.date_range` API. ### How was this patch tested? Enabling the existing UT. Closes apache#42389 from itholic/closed_removing. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to remove
closedparameter fromps.date_range& enable test. See pandas-dev/pandas#40245 more detail.Why are the changes needed?
To support pandas 2.0.0 and above.
Does this PR introduce any user-facing change?
closedparameter will no longer available fromps.date_rangeAPI.How was this patch tested?
Enabling the existing UT.