Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-41471][SQL] Reduce Spark shuffle when only one side of a join is KeyGroupedPartitioning #42194
[SPARK-41471][SQL] Reduce Spark shuffle when only one side of a join is KeyGroupedPartitioning #42194
Changes from 11 commits
bc7f179
260d054
2a29387
b2b3a10
cb82be4
7c6cc23
50632c7
5a4a6dc
31eca2d
030516e
fa93c66
82488fb
a1db61d
3a7ea49
21255cf
1a5e2b7
3c98fd7
5d227f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we make the algorithm smarter? If the other side is large, doing a
KeyGroupedPartitioning
may lead to skew and it's still better to shuffle both sides with hash partitioning.Let's think of an extreme case: one side reports
KeyGroupedPartitioning
with only one partition, with this optimization, we end up with doing the join using a single thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
ShuffleSpec
"framework" inEnsureRequirements
already takes this into consideration. This PR mainly makesKeyGroupedShuffleSpec
behaves similar toHashShuffleSpec
and be able to shuffle the other side (via makingcanCreatePartitioning
return true).