Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43974][CONNECT][BUILD][FOLLOWUP] Upgrade buf to v1.23.1 #41934

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Jul 11, 2023

What changes were proposed in this pull request?

The pr is followup SPARK-43974.

Why are the changes needed?

image

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@panbingkun
Copy link
Contributor Author

cc @zhengruifeng

@LuciferYang
Copy link
Contributor

LuciferYang commented Jul 11, 2023

Can you add some descriptions in the Why are the changes needed?? It is difficult to search in the commit log for screenshots.

@HyukjinKwon
Copy link
Member

How does this related to #41933?

@LuciferYang
Copy link
Contributor

How does this related to #41933?

I think they fixed the same issue

@panbingkun
Copy link
Contributor Author

How does this related to #41933?

Yes, that's right.

@panbingkun
Copy link
Contributor Author

image From the test results, it is not a problem with the Buf version.

@panbingkun panbingkun marked this pull request as draft July 11, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants