[SPARK-42876][SQL] DataType's physicalDataType should be private[sql] #40499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
reviewed
Mar 21, 2023
| @@ -119,7 +119,7 @@ abstract class DataType extends AbstractDataType { | |||
|
|
|||
| override private[sql] def acceptsType(other: DataType): Boolean = sameType(other) | |||
|
|
|||
| def physicalDataType: PhysicalDataType = UninitializedPhysicalType | |||
| private[sql] def physicalDataType: PhysicalDataType = UninitializedPhysicalType | |||
There was a problem hiding this comment.
can we change the modifier in subclasses as well?
HyukjinKwon
approved these changes
Mar 21, 2023
cloud-fan
approved these changes
Mar 21, 2023
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 21, 2023
### What changes were proposed in this pull request? `physicalDataType` should not be a public API but be private[sql]. ### Why are the changes needed? This is to limit API scope to not expose unnecessary API to be public. ### Does this PR introduce _any_ user-facing change? No since we have not released Spark 3.4.0 yet. ### How was this patch tested? N/A Closes #40499 from amaliujia/change_scope_of_physical_data_type. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c9a530e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
also cc @xinrong-meng this is from api auditing |
yaooqinn
pushed a commit
that referenced
this pull request
Mar 24, 2023
…d generating API doc ### What changes were proposed in this pull request? This is the only issue I found during SQL module API auditing via apache/spark-website@6159860 . Somehow `protected[sql]` also generates API doc which is unexpected. `private[sql]` solves the problem and I generated doc locally to verify it. Another API issue has been fixed by #40499 ### Why are the changes needed? fix api doc ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes #40541 from cloud-fan/auditing. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
yaooqinn
pushed a commit
that referenced
this pull request
Mar 24, 2023
…d generating API doc ### What changes were proposed in this pull request? This is the only issue I found during SQL module API auditing via apache/spark-website@6159860 . Somehow `protected[sql]` also generates API doc which is unexpected. `private[sql]` solves the problem and I generated doc locally to verify it. Another API issue has been fixed by #40499 ### Why are the changes needed? fix api doc ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes #40541 from cloud-fan/auditing. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit f7421b4) Signed-off-by: Kent Yao <yao@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? `physicalDataType` should not be a public API but be private[sql]. ### Why are the changes needed? This is to limit API scope to not expose unnecessary API to be public. ### Does this PR introduce _any_ user-facing change? No since we have not released Spark 3.4.0 yet. ### How was this patch tested? N/A Closes apache#40499 from amaliujia/change_scope_of_physical_data_type. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c9a530e) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…d generating API doc ### What changes were proposed in this pull request? This is the only issue I found during SQL module API auditing via apache/spark-website@6159860 . Somehow `protected[sql]` also generates API doc which is unexpected. `private[sql]` solves the problem and I generated doc locally to verify it. Another API issue has been fixed by apache#40499 ### Why are the changes needed? fix api doc ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes apache#40541 from cloud-fan/auditing. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Kent Yao <yao@apache.org> (cherry picked from commit f7421b4) Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
physicalDataTypeshould not be a public API but be private[sql].Why are the changes needed?
This is to limit API scope to not expose unnecessary API to be public.
Does this PR introduce any user-facing change?
No since we have not released Spark 3.4.0 yet.
How was this patch tested?
N/A