[SPARK-42548][SQL] Add ReferenceAllColumns to skip rewriting attributes #40154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses-you
commented
Feb 24, 2023
| val t2 = LocalRelation(AttributeReference("c", DecimalType(2, 0))()) | ||
| val unresolved = t1.union(t2).select(UnresolvedStar(None)) | ||
| val plainReferences = FakePlainReferences(unresolved) | ||
| val wp1 = widenSetOperationTypes(plainReferences.select(t1.output.head)) |
There was a problem hiding this comment.
before, it would throw
org.apache.spark.sql.catalyst.analysis.UnresolvedException: Invalid call to toAttribute on unresolved object
cloud-fan
reviewed
Feb 24, 2023
| * | ||
| * Note, the only used place is at [[QueryPlan.transformUpWithNewOutput]]. | ||
| */ | ||
| trait PlainReferences[PlanType <: QueryPlan[PlanType]] { self: QueryPlan[PlanType] => |
There was a problem hiding this comment.
how about ReferenceAllColumns
cloud-fan
approved these changes
Feb 24, 2023
ulysses-you
changed the title
ulysses-you
force-pushed
the
references
branch
from
afd9c26 to
0871156
Compare
ulysses-you
force-pushed
the
references
branch
from
0871156 to
80dd679
Compare
|
@cloud-fan can we have this in branch-3.4 ? since it prevent potential bug and it's friendly for developers. |
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 28, 2023
### What changes were proposed in this pull request? Add a new trait `ReferenceAllColumns ` that overrides `references` using children output. Then we can skip it during rewriting attributes in transformUpWithNewOutput. ### Why are the changes needed? There are two reasons with this new trait: 1. it's dangerous to call `references` on an unresolved plan that all of references come from children 2. it's unnecessary to rewrite its attributes that all of references come from children ### Does this PR introduce _any_ user-facing change? prevent potential bug ### How was this patch tested? add test and pass CI Closes #40154 from ulysses-you/references. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit db0e822) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Add a new trait `ReferenceAllColumns ` that overrides `references` using children output. Then we can skip it during rewriting attributes in transformUpWithNewOutput. ### Why are the changes needed? There are two reasons with this new trait: 1. it's dangerous to call `references` on an unresolved plan that all of references come from children 2. it's unnecessary to rewrite its attributes that all of references come from children ### Does this PR introduce _any_ user-facing change? prevent potential bug ### How was this patch tested? add test and pass CI Closes apache#40154 from ulysses-you/references. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit db0e822) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a new trait
ReferenceAllColumnsthat overridesreferencesusing children output. Then we can skip it during rewriting attributes in transformUpWithNewOutput.Why are the changes needed?
There are two reasons with this new trait:
referenceson an unresolved plan that all of references come from childrenDoes this PR introduce any user-facing change?
prevent potential bug
How was this patch tested?
add test and pass CI