-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5068][SQL]fix bug query data when path doesn't exists #3907
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.sql.hive | ||
|
||
import java.io.File | ||
|
||
import com.google.common.io.Files | ||
import org.apache.spark.sql.{QueryTest, _} | ||
import org.apache.spark.sql.hive.test.TestHive | ||
/* Implicits */ | ||
import org.apache.spark.sql.hive.test.TestHive._ | ||
|
||
|
||
class QueryPartitionSuite extends QueryTest { | ||
|
||
test("SPARK-5068: query data when path doesn't exists"){ | ||
val testData = TestHive.sparkContext.parallelize( | ||
(1 to 10).map(i => TestData(i, i.toString))) | ||
testData.registerTempTable("testData") | ||
|
||
val tmpDir = Files.createTempDir() | ||
//create the table for test | ||
sql(s"CREATE TABLE table_with_partition(key int,value string) PARTITIONED by (ds string) location '${tmpDir.toURI.toString}' ") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='1') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='2') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='3') SELECT key,value FROM testData") | ||
sql("INSERT OVERWRITE TABLE table_with_partition partition (ds='4') SELECT key,value FROM testData") | ||
//test for the exist path | ||
checkAnswer(sql("select key,value from table_with_partition"), | ||
testData.collect.toSeq ++ testData.collect.toSeq ++ testData.collect.toSeq ++ testData.collect.toSeq) | ||
|
||
//delect the path of one partition | ||
val folders = tmpDir.listFiles.filter(_.isDirectory).toList | ||
def deleteAll(file:File){ | ||
if (file.isDirectory()) { | ||
for (f:File <-file.listFiles()) { | ||
deleteAll(f); | ||
} | ||
} | ||
file.delete(); | ||
} | ||
deleteAll(folders(0)) | ||
|
||
//test for the affter delete the path | ||
checkAnswer(sql("select key,value from table_with_partition"), | ||
testData.collect.toSeq ++ testData.collect.toSeq ++ testData.collect.toSeq) | ||
|
||
sql("DROP TABLE table_with_partition") | ||
sql("DROP TABLE createAndInsertTest") | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more direct and reliable way to detect if the path doesn't exist here than catching a general exception? this risks silently swallowing errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about to give a log warning when the path is not found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess throwing exception is the way how
InputFormat
handle the non-existed file. I agree with @srowen , we couldn't just ignore the error here. Probably it's better to leave the current implementation unchanged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review.In my understanding,this method is get the data for specific partition by return
Array[Partition]
.I think get when we pass the wrong path and we return an empty array is OK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
HadoopRDD
is general API for reading files, I don't think it's acceptable the API just keep silence if the specified path doesn't exist, throwing an exception probably better.Take the JDK class
FileReader
for example:http://docs.oracle.com/javase/7/docs/api/java/io/FileReader.html#FileReader(java.io.File)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found Shark is check for the path when the RDD was constructed(a little bit like my last PR),but i agree with @marmbrus that will slow down when constructing RDD especially a lot of partitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I understand the background now.
You're right, we do need to follow the Hive's behavior, the non-existed partition will returns an empty record iterator, other than throw exception. However, this should be LIMITED within Hive TableReader, not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And of course, or we can add a new parameter for
HadoopRDD
(e.g.throwExceptionOnError: Boolean = true
?), to support the case you described.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @chenghao-intel, we'd better handle this in hive module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review!I have two questions:
1.How could i limited within hive by catch exption instead of using
fs.exists
to find out the wrong patition?2.Could add a new parameter in
HadoopRDD
affect more code?