-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-38921][K8S][Tests] Use k8s-client to create queue resource in Volcano IT #36219
Conversation
This is manually volcano test results. |
Here is complete test results (all k8s test also include volcano) with Yikun@55af9d8 (will add a pr after this patch merged): https://github.com/Yikun/spark/runs/6046699187?check_suite_focus=true |
All exsiting CI passed: https://github.com/Yikun/spark/actions/runs/2176142324 |
@dongjoon-hyun Could you take a look? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Yikun .
- I don't think this is an urgent refactoring because there is no test coverage change here.
- Refactoring always increases the complexity of backporting process. This is not helpful during 3.3 release process.
- Hence, I'd like to recommend to keep this PR open for a while until Apache Spark 3.3 release and revisit after that.
@dongjoon-hyun Sure, I'm fine with it. |
Thank you, @Yikun . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Yikun . I'm revisiting K8s PRs for Apache Spark 3.4.
Could you rebase this PR and make all CIs green, please?
@dongjoon-hyun Thanks for taking care of this! Will rebase and retest soon |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Merged to master for Apache Spark 3.4.0. |
…Volcano IT ### What changes were proposed in this pull request? Use fabric8io/k8s-client to create queue resource in Volcano IT. ### Why are the changes needed? Use k8s-client to create volcano queue to - Make code easy to understand - Enable abity to set queue capacity dynamically. This will help to support running Volcano test in a resource limited env (such as github action). ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Volcano IT passed Closes apache#36219 from Yikun/SPARK-38921. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…Volcano IT ### What changes were proposed in this pull request? Use fabric8io/k8s-client to create queue resource in Volcano IT. ### Why are the changes needed? Use k8s-client to create volcano queue to - Make code easy to understand - Enable abity to set queue capacity dynamically. This will help to support running Volcano test in a resource limited env (such as github action). ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Volcano IT passed Closes #36219 from Yikun/SPARK-38921. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a49f66f) Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Backport to branch-3.3 (3.3.2), See also #38789 (comment) . |
What changes were proposed in this pull request?
Use fabric8io/k8s-client to create queue resource in Volcano IT.
Why are the changes needed?
Use k8s-client to create volcano queue to
Does this PR introduce any user-facing change?
No
How was this patch tested?
Volcano IT passed