Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4756][SQL] FIX: sessionToActivePool grow infinitely, even as sessions expire #3617

Closed
wants to merge 3 commits into from

Conversation

guowei2
Copy link
Contributor

@guowei2 guowei2 commented Dec 5, 2014

sessionToActivePool in SparkSQLOperationManager grow infinitely, even as sessions expire.
we should remove the pool value when the session closed, even though sessionToActivePool would not exist in all of sessions.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

marmbrus commented Dec 5, 2014

ok to test

@SparkQA
Copy link

SparkQA commented Dec 5, 2014

Test build #24185 has started for PR 3617 at commit e070998.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 5, 2014

Test build #24185 has finished for PR 3617 at commit e070998.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24185/
Test FAILed.

@guowei2
Copy link
Contributor Author

guowei2 commented Dec 6, 2014

Sorry for that.
i have a mistake about not test with shim12

@SparkQA
Copy link

SparkQA commented Dec 6, 2014

Test build #24204 has started for PR 3617 at commit e9b97b8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 6, 2014

Test build #24204 has finished for PR 3617 at commit e9b97b8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24204/
Test PASSed.

@marmbrus
Copy link
Contributor

/cc @liancheng

@liancheng
Copy link
Contributor

This is a known issue, and the solution provided in this PR LGTM, thanks!

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in 22ddb6e Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants