-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4692] [SQL] Support ! boolean logic operator like NOT #3555
Conversation
Test build #24041 has started for PR 3555 at commit
|
Test build #24041 has finished for PR 3555 at commit
|
Test PASSed. |
Please add a test to |
Test build #24070 has started for PR 3555 at commit
|
Test build #24070 has finished for PR 3555 at commit
|
Test FAILed. |
Test build #24076 has started for PR 3555 at commit
|
Test build #24076 has finished for PR 3555 at commit
|
Test PASSed. |
Do other SQL dialects support this? I think we should avoid too much non-standard syntax. |
How about we switch this to a query test (YanTangZhai#14). otherwise LGTM |
Use createQueryTest
Test build #24583 has started for PR 3555 at commit
|
Test build #24583 has finished for PR 3555 at commit
|
Test PASSed. |
@marmbrus Please review again. Thanks. |
Test FAILed. |
Ah, sorry, forgot that the golden answer file name is generated by the MD5 of the query string. Then let's revert the last space change. I think this minor issue doesn't worth the trouble. Sorry for the inconvenience... |
@liancheng I will revert the last space change. Thanks for your comment. |
Test build #24702 has started for PR 3555 at commit
|
Test build #24702 has finished for PR 3555 at commit
|
Test PASSed. |
Thanks for the update, this now LGTM. |
Hey sorry, this has merge conflicts. Can you merge with master? |
Test build #24935 has started for PR 3555 at commit
|
Test build #24939 has started for PR 3555 at commit
|
Test build #24940 has started for PR 3555 at commit
|
Test build #24935 has finished for PR 3555 at commit
|
Test PASSed. |
@marmbrus I've updated it. Please review again. |
Test build #24939 has finished for PR 3555 at commit
|
Test PASSed. |
Test build #24940 has finished for PR 3555 at commit
|
Test PASSed. |
Thanks! I've merged this to master. |
Support ! boolean logic operator like NOT in sql as follows
select * from for_test where !(col1 > col2)