-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35825][INFRA][FOLLOWUP] Increase it in build/mvn script #33180
Conversation
How do you think about this, @gengliangwang , @HyukjinKwon , and @LuciferYang . |
Retest this please |
Kubernetes integration test unable to build dist. exiting with code: 1 |
Kubernetes integration test starting |
Kubernetes integration test status success |
This problem often occurs in my local compilation recently, let me add this arg to verify the compilation problem. On the other hand, is |
Thank you, @LuciferYang ! Yes, it would be great if you can test this locally. |
Increasing to
BTW, this is a follow-up. And, original PR is the following. This PR is consistent with the original PR in terms of the values. |
Test build #140548 has finished for PR 33180 at commit
|
LGTM. @LuciferYang what is the local test result? |
Test build #140552 has finished for PR 33180 at commit
|
The above Maven run actually passed the compilation on
And, there is another Maven run is still running. |
Since this is a flaky compilation issue, the above two Maven runs might be insufficient for verification. However, I believe this patch is no harm for the build and only provides the consistency for Maven. |
I'll merge this. Please let us know your result when you have some time, @LuciferYang ~ |
@dongjoon-hyun @gengliangwang It seems to work, I have compile and test catalyst and related modules for many times in my compilation environment, no |
Oh! Thank you for sharing that, @LuciferYang . Ya, I saw this on |
Yes, the |
@dongjoon-hyun @LuciferYang Awesome, hopefully the issue is resolved this time. |
Yep, I will keep monitoring. BTW, I saw branch-3.2. Thank you, @gengliangwang . |
Test build #140551 has finished for PR 33180 at commit
|
What changes were proposed in this pull request?
This is a follow up of #32961.
This PR additionally sets the stack size in
build/mvn
.Why are the changes needed?
We are still hitting
StackOverflowError
in Jenkins.This PR increases the JVM of
mvn
instead of the plugin.Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A