[SPARK-35351][SQL][FOLLOWUP] Avoid using loaded variable for LEFT ANTI SMJ code-gen
#32681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @viirya, @maropu and @cloud-fan, thanks. |
viirya
approved these changes
May 27, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
cloud-fan
approved these changes
May 27, 2021
|
thanks, merging to master! |
|
Test build #138992 has finished for PR 32681 at commit
|
|
Thank you @cloud-fan and @viirya for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup from #32547 (comment), where for LEFT ANTI join, we do not need to depend on
loadedvariable, as incodegenAntiwe only loadstreamedAfterno more than once (i.e. assign column values from streamed row which are not used in join condition).Why are the changes needed?
Avoid unnecessary processing in code-gen (though it's just
boolean $loaded = false;, andif (!$loaded) { $loaded = true; }).Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unite tests in
ExistenceJoinSuite.