Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark Core] SPARK-4380 Edit spilling log from MB to B #3243

Closed
wants to merge 5 commits into from
Closed

[Spark Core] SPARK-4380 Edit spilling log from MB to B #3243

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
946351c
Edit spilling log from MB to B
shenh062326 Nov 13, 2014
da761c2
Edit spilling log from MB to B
shenh062326 Nov 14, 2014
e9145e8
Edit spilling log from MB to B
shenh062326 Nov 14, 2014
21ee960
Edit spilling log from MB to B
shenh062326 Nov 14, 2014
4653378
Edit spilling log from MB to B
shenh062326 Nov 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/util/collection/Spillable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private[spark] trait Spillable[C] {
*/
@inline private def logSpillage(size: Long) {
val threadId = Thread.currentThread().getId
logInfo("Thread %d spilling in-memory map of %d MB to disk (%d time%s so far)"
.format(threadId, size / (1024 * 1024), _spillCount, if (_spillCount > 1) "s" else ""))
logInfo("Thread %d spilling in-memory map of %d B to disk (%d time%s so far)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better idea: use Utils.bytesToString to intelligently create a string like "20KB" or "3MB" or "139B" depending on the magnitude.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that should produce the most human readable format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Srowen, change to Utils.bytesToString.

.format(threadId, size, _spillCount, if (_spillCount > 1) "s" else ""))
}
}