[SPARK-35250][SQL][DOCS] Fix duplicated STOP_AT_DELIMITER to SKIP_VALUE at CSV's unescapedQuoteHandling option documentation #32423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eHandling option documentation
|
cc @LuciferYang FYI |
srowen
approved these changes
May 3, 2021
dongjoon-hyun
approved these changes
May 3, 2021
|
Thanks guys! Merged to master and branch-3.1. |
HyukjinKwon
added a commit
that referenced
this pull request
May 3, 2021
…UE at CSV's unescapedQuoteHandling option documentation ### What changes were proposed in this pull request? This is rather a followup of #30518 that should be ported back to `branch-3.1` too. `STOP_AT_DELIMITER` was mistakenly used twice. The duplicated `STOP_AT_DELIMITER` should be `SKIP_VALUE` in the documentation. ### Why are the changes needed? To correctly document. ### Does this PR introduce _any_ user-facing change? Yes, it fixes the user-facing documentation. ### How was this patch tested? I checked them via running linters. Closes #32423 from HyukjinKwon/SPARK-35250. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 8aaa9e8) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Thank you for your fix @HyukjinKwon , I'm on vacation, so I'm not online these days :) |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…UE at CSV's unescapedQuoteHandling option documentation ### What changes were proposed in this pull request? This is rather a followup of apache#30518 that should be ported back to `branch-3.1` too. `STOP_AT_DELIMITER` was mistakenly used twice. The duplicated `STOP_AT_DELIMITER` should be `SKIP_VALUE` in the documentation. ### Why are the changes needed? To correctly document. ### Does this PR introduce _any_ user-facing change? Yes, it fixes the user-facing documentation. ### How was this patch tested? I checked them via running linters. Closes apache#32423 from HyukjinKwon/SPARK-35250. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 8aaa9e8) Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit 89f5ec7) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is rather a followup of #30518 that should be ported back to
branch-3.1too.STOP_AT_DELIMITERwas mistakenly used twice. The duplicatedSTOP_AT_DELIMITERshould beSKIP_VALUEin the documentation.Why are the changes needed?
To correctly document.
Does this PR introduce any user-facing change?
Yes, it fixes the user-facing documentation.
How was this patch tested?
I checked them via running linters.