Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35061][BUILD] Upgrade pycodestyle from 2.6.0 to 2.7.0 #32160

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR bumps up the version of pycodestyle from 2.6.0 to 2.7.0 released a month ago.

Why are the changes needed?

2.7.0 includes three major fixes below (see https://readthedocs.org/projects/pycodestyle/downloads/pdf/latest/):

The first and third ones could be useful for dev to detect the styles.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually tested locally.

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41908/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41908/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137328 has finished for PR 32160 at commit a9f9893.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41922/

@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41922/

@github-actions
Copy link

Test build #748029554 for PR 32160 at commit a9f9893.

@github-actions github-actions bot added the BUILD label Apr 14, 2021
@SparkQA
Copy link

SparkQA commented Apr 14, 2021

Test build #137343 has finished for PR 32160 at commit fe07e5c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master. Thanks, @HyukjinKwon .

@github-actions
Copy link

Test build #748029554 for PR 32160 at commit fe07e5c.

@HyukjinKwon
Copy link
Member Author

Thank you @dongjoon-hyun !

@HyukjinKwon HyukjinKwon deleted the SPARK-35061 branch January 4, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants