Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33906][WEBUI] Fix the bug of UI Executor page stuck due to undefined peakMemoryMetrics #30920

Closed
wants to merge 3 commits into from
Closed

[SPARK-33906][WEBUI] Fix the bug of UI Executor page stuck due to undefined peakMemoryMetrics #30920

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3ab7a1
Check if the peakMemoryMetrics is undefined before accessing it
Dec 24, 2020
e7154fd
Update display text to N/A when peakMemoryMetrics is undefined
Dec 25, 2020
2f7b9be
Update display text to 0.0 B / 0.0 B
Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions core/src/main/resources/org/apache/spark/ui/static/executorspage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,9 @@ $(document).ready(function () {
},
{
data: function (row, type) {
if (typeof row.peakMemoryMetrics == "undefined") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use === and !== rather than == and !=.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

return "";
}
if (type !== 'display')
return row.peakMemoryMetrics.JVMHeapMemory;
else
Expand All @@ -423,6 +426,9 @@ $(document).ready(function () {
},
{
data: function (row, type) {
if (typeof row.peakMemoryMetrics == "undefined") {
return "";
}
if (type !== 'display')
return row.peakMemoryMetrics.OnHeapExecutionMemory;
else
Expand All @@ -432,6 +438,9 @@ $(document).ready(function () {
},
{
data: function (row, type) {
if (typeof row.peakMemoryMetrics == "undefined") {
return "";
}
if (type !== 'display')
return row.peakMemoryMetrics.OnHeapStorageMemory;
else
Expand All @@ -441,6 +450,9 @@ $(document).ready(function () {
},
{
data: function (row, type) {
if (typeof row.peakMemoryMetrics == "undefined") {
return "";
}
if (type !== 'display')
return row.peakMemoryMetrics.DirectPoolMemory;
else
Expand Down