Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-33695][BUILD] Upgrade to jackson to 2.10.5 and jackson-databind to 2.10.5.1 #30656

Closed
wants to merge 2 commits into from
Closed

[SPARK-33695][BUILD] Upgrade to jackson to 2.10.5 and jackson-databind to 2.10.5.1 #30656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e40796
Upgrade to jackson to 2.10.5 and jackson-databind to 2.10.5.1
n-marion Dec 7, 2020
7040f75
Update manifest files.
n-marion Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@
<!-- for now, not running scalafmt as part of default verify pipeline -->
<scalafmt.skip>true</scalafmt.skip>
<codehaus.jackson.version>1.9.13</codehaus.jackson.version>
<fasterxml.jackson.version>2.10.0</fasterxml.jackson.version>
<fasterxml.jackson.version>2.10.5</fasterxml.jackson.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot bump up it to 2.12.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking over Jackson's release information both Jackson Release 2.11 and Jackson Release 2.12 showed a large amounts of changes; and although I could attempt a build to make sure compilation fails, I'd personally be uncertain that unit tests would be sufficient enough to ensure compatibility.

<fasterxml.jackson-databind.version>2.10.5.1</fasterxml.jackson-databind.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you added a new entry here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jackson does this often and databind sometimes has a different subrevision. This follows the previous style before the recent update.

<snappy.version>1.1.8</snappy.version>
<netlib.java.version>1.1.2</netlib.java.version>
<commons-codec.version>1.10</commons-codec.version>
Expand Down Expand Up @@ -773,7 +774,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${fasterxml.jackson.version}</version>
<version>${fasterxml.jackson-databind.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand Down