-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33523][SQL][TEST] Add predicate related benchmark to SubExprEliminationBenchmark #30476
Conversation
------------------------------------------------------------------------------------------------------------------------- | ||
subexpressionElimination off, codegen on 42687 42805 111 0.0 426873372.5 1.0X | ||
subexpressionElimination off, codegen off 43606 45108 1613 0.0 436055236.3 1.0X | ||
subexpressionElimination on, codegen on 29761 30563 704 0.0 297614324.4 1.4X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, do we have only 40% improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems so, it is subexpression elimination under codegen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will submit subexpression elimination under non-codegen after this.
This comment has been minimized.
This comment has been minimized.
retest this please |
sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/SubExprEliminationBenchmark.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @viirya
GA passed. |
Thanks @HyukjinKwon @dongjoon-hyun @maropu |
Test build #131615 has finished for PR 30476 at commit
|
Test build #131618 has finished for PR 30476 at commit
|
Test build #131613 has finished for PR 30476 at commit
|
What changes were proposed in this pull request?
This patch adds predicate related benchmark to
SubExprEliminationBenchmark
.Why are the changes needed?
We should have a benchmark for subexpression elimination of predicate.
Does this PR introduce any user-facing change?
No, dev only.
How was this patch tested?
Run benchmark locally.