-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33166][DOC] Provide Search Function in Spark docs site #30292
Closed
Closed
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
4a6f903
Reuse completeNextStageWithFetchFailure
beliefer 96456e2
Merge remote-tracking branch 'upstream/master'
beliefer 4314005
Merge remote-tracking branch 'upstream/master'
beliefer d6af4a7
Merge remote-tracking branch 'upstream/master'
beliefer f69094f
Merge remote-tracking branch 'upstream/master'
beliefer b86a42d
Merge remote-tracking branch 'upstream/master'
beliefer 2ac5159
Merge branch 'master' of github.com:beliefer/spark
beliefer 9021d6c
Merge remote-tracking branch 'upstream/master'
beliefer 74a2ef4
Merge branch 'master' of github.com:beliefer/spark
beliefer 9828158
Merge remote-tracking branch 'upstream/master'
beliefer 9cd1aaf
Merge remote-tracking branch 'upstream/master'
beliefer abfcbb9
Merge remote-tracking branch 'upstream/master'
beliefer 07c6c81
Merge remote-tracking branch 'upstream/master'
beliefer 580130b
Merge remote-tracking branch 'upstream/master'
beliefer 3712808
Merge branch 'master' of github.com:beliefer/spark
beliefer 6107413
Merge remote-tracking branch 'upstream/master'
beliefer 4b799b4
Merge remote-tracking branch 'upstream/master'
beliefer ee0ecbf
Merge remote-tracking branch 'upstream/master'
beliefer 596bc61
Merge remote-tracking branch 'upstream/master'
beliefer 0164e2f
Merge remote-tracking branch 'upstream/master'
beliefer 90b79fc
Merge remote-tracking branch 'upstream/master'
beliefer 2cef3a9
Merge remote-tracking branch 'upstream/master'
beliefer c26b64f
Merge remote-tracking branch 'upstream/master'
beliefer 2e02cd2
Merge remote-tracking branch 'upstream/master'
beliefer a6d0741
Merge remote-tracking branch 'upstream/master'
beliefer 82e5b2c
Merge remote-tracking branch 'upstream/master'
beliefer 70bbf5d
Merge remote-tracking branch 'upstream/master'
beliefer 6f6471c
Try to add doc search.
beliefer 3607e23
Optmize code
beliefer cae8dd1
Optmize code
beliefer 3a6bf0b
Update css
beliefer 5949977
Add comments
beliefer 9c9d639
Update css.
beliefer 7120c5b
Optimize css
beliefer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* Main dropdown wrapper */ | ||
.algolia-autocomplete .ds-dropdown-menu { | ||
width: 500px; | ||
} | ||
|
||
/* Main category (eg. Getting Started) */ | ||
.algolia-autocomplete .algolia-docsearch-suggestion--category-header { | ||
color: darkgray; | ||
border: 1px underline gray; | ||
} | ||
|
||
/* Category (eg. Downloads) */ | ||
.algolia-autocomplete .algolia-docsearch-suggestion--subcategory-column { | ||
color: gray; | ||
} | ||
|
||
/* Title (eg. Bootstrap CDN) */ | ||
.algolia-autocomplete .algolia-docsearch-suggestion--title { | ||
font-weight: bold; | ||
color: black; | ||
} | ||
|
||
/* Description description (eg. Bootstrap currently works...) */ | ||
.algolia-autocomplete .algolia-docsearch-suggestion--text { | ||
font-size: 0.8rem; | ||
color: gray; | ||
} | ||
|
||
/* Highlighted text */ | ||
.algolia-autocomplete .algolia-docsearch-suggestion--highlight { | ||
color: blue; | ||
} | ||
|
||
.searchbox { | ||
margin-top: 2%; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all the external css/js files for Spark UI/Doc, we always download it and make it as part of the source code.
I think this is to make sure Spark UI/Doc can be run and accessed in a private network.
However, it seems fine for Spark Doc to use external link for CSS/JS file. cc @srowen @sarutak , WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, HistoryServer is used within a closed network so I think it's better to make css/js as part of source code for WebUI.
On the other hand, I think it's fine for docs to use external link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. the
docsearch.js
maybe associate with external search engines. It's not good to copy as part of source code.