[SPARK-33094][SQL][3.0] Make ORC format propagate Hadoop config from DS options to underlying HDFS file system #29985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions to underlying HDFS file system
Propagate ORC options to Hadoop configs in Hive `OrcFileFormat` and in the regular ORC datasource.
There is a bug that when running:
```scala
spark.read.format("orc").options(conf).load(path)
```
The underlying file system will not receive the conf options.
Yes
Added UT to `OrcSourceSuite`.
Closes apache#29976 from MaxGekk/orc-option-propagation.
Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit c5f6af9)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
The changes conflict with |
HyukjinKwon
approved these changes
Oct 9, 2020
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 9, 2020
…DS options to underlying HDFS file system
### What changes were proposed in this pull request?
Propagate ORC options to Hadoop configs in Hive `OrcFileFormat` and in the regular ORC datasource.
### Why are the changes needed?
There is a bug that when running:
```scala
spark.read.format("orc").options(conf).load(path)
```
The underlying file system will not receive the conf options.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Added UT to `OrcSourceSuite`.
Authored-by: Max Gekk <max.gekkgmail.com>
Signed-off-by: Dongjoon Hyun <dhyunapple.com>
(cherry picked from commit c5f6af9)
Signed-off-by: Max Gekk <max.gekkgmail.com>
Closes #29985 from MaxGekk/orc-option-propagation-3.0.
Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
|
Merged to branch-3.0. Sure, let's open a PR for branch-2.4 as well. |
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Oct 9, 2020
…DS options to underlying HDFS file system
Propagate ORC options to Hadoop configs in Hive `OrcFileFormat` and in the regular ORC datasource.
There is a bug that when running:
```scala
spark.read.format("orc").options(conf).load(path)
```
The underlying file system will not receive the conf options.
Yes
Added UT to `OrcSourceSuite`.
Authored-by: Max Gekk <max.gekkgmail.com>
Signed-off-by: Dongjoon Hyun <dhyunapple.com>
(cherry picked from commit c5f6af9)
Signed-off-by: Max Gekk <max.gekkgmail.com>
Closes apache#29985 from MaxGekk/orc-option-propagation-3.0.
Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 9892b3e)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Here is the backport to 2.4: #29987 |
|
Test build #129582 has finished for PR 29985 at commit
|
|
+1, late LGTM. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…DS options to underlying HDFS file system
### What changes were proposed in this pull request?
Propagate ORC options to Hadoop configs in Hive `OrcFileFormat` and in the regular ORC datasource.
### Why are the changes needed?
There is a bug that when running:
```scala
spark.read.format("orc").options(conf).load(path)
```
The underlying file system will not receive the conf options.
### Does this PR introduce _any_ user-facing change?
Yes
### How was this patch tested?
Added UT to `OrcSourceSuite`.
Authored-by: Max Gekk <max.gekkgmail.com>
Signed-off-by: Dongjoon Hyun <dhyunapple.com>
(cherry picked from commit c5f6af9)
Signed-off-by: Max Gekk <max.gekkgmail.com>
Closes apache#29985 from MaxGekk/orc-option-propagation-3.0.
Authored-by: Max Gekk <max.gekk@gmail.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Propagate ORC options to Hadoop configs in Hive
OrcFileFormatand in the regular ORC datasource.Why are the changes needed?
There is a bug that when running:
spark.read.format("orc").options(conf).load(path)The underlying file system will not receive the conf options.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Added UT to
OrcSourceSuite.Authored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Dongjoon Hyun dhyun@apple.com
(cherry picked from commit c5f6af9)
Signed-off-by: Max Gekk max.gekk@gmail.com