[SPARK-32258][SQL] NormalizeFloatingNumbers directly normalizes IF/CaseWhen/Coalesce child expressions #29061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #125516 has started for PR 29061 at commit |
This comment has been minimized.
This comment has been minimized.
maropu
reviewed
Jul 10, 2020
.../test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
Outdated
Show resolved
Hide resolved
maropu
approved these changes
Jul 10, 2020
HyukjinKwon
reviewed
Jul 10, 2020
.../test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
Outdated
Show resolved
Hide resolved
...talyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
Show resolved
Hide resolved
viirya
changed the title
|
cc @cloud-fan |
cloud-fan
reviewed
Jul 10, 2020
...talyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
Show resolved
Hide resolved
|
Test build #125542 has finished for PR 29061 at commit
|
|
Test build #125706 has finished for PR 29061 at commit
|
|
retest this please |
|
Test build #125707 has finished for PR 29061 at commit
|
dongjoon-hyun
changed the title
.../test/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingPointNumbersSuite.scala
Outdated
Show resolved
Hide resolved
...talyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
Show resolved
Hide resolved
|
Test build #125719 has finished for PR 29061 at commit
|
dongjoon-hyun
approved these changes
Jul 12, 2020
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya and all.
Merged to master for Apache Spark 3.1.0 on December 2020.
cloud-fan
reviewed
Jul 13, 2020
|
|
||
| case Coalesce(children) => | ||
| Coalesce(children.map(normalize)) | ||
|
|
||
| case _ if expr.dataType == FloatType || expr.dataType == DoubleType => |
There was a problem hiding this comment.
Shall we put these new cases after this case? The main goal of this optimization is to avoid constructing a new CreateStruct during normalization. If it's just a float/double type If/CashWhen/Coalesce, it's actually an overhead to duplicate the normalization work in each child.
cloud-fan
pushed a commit
that referenced
this pull request
Jul 14, 2020
…double If/CaseWhen/Coalesce ### What changes were proposed in this pull request? This is followup to #29061. See #29061 (comment). Basically this moves If/CaseWhen/Coalesce case patterns after float/double case so we don't duplicate normalization on children for float/double If/CaseWhen/Coalesce. ### Why are the changes needed? Simplify expression tree. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Modify unit tests. Closes #29091 from viirya/SPARK-32258-followup. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch proposes to let
NormalizeFloatingNumbersrule directly normalizes on certain children expressions. It could simplify expression tree.Why are the changes needed?
Currently NormalizeFloatingNumbers rule treats some expressions as black box but we can optimize it a bit by normalizing directly the inner children expressions.
Also see #28962 (comment).
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests.