Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29554][SQL][FOLLOWUP] Rename Version to SparkVersion #26647

Closed
wants to merge 1 commit into from
Closed

[SPARK-29554][SQL][FOLLOWUP] Rename Version to SparkVersion #26647

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 24, 2019

What changes were proposed in this pull request?

This is a follow-up of #26209 .
This renames class Version to class SparkVersion.

Why are the changes needed?

According to the review comment, this uses more specific class name.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the existing tests.

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @maropu .

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All compilation tests passed and MiscFunctionsSuite is tested locally.
Merged to master. Thank you, @maropu .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-29554 branch November 24, 2019 03:54
@SparkQA
Copy link

SparkQA commented Nov 24, 2019

Test build #114330 has finished for PR 26647 at commit ccf3ea3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class SparkVersion() extends LeafExpression with CodegenFallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants