[SQL] Add type checking debugging functions #2657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
…fix to denote invalid or unresolved nodes.
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
|
QA tests have started for PR 2657 at commit
|
|
QA tests have finished for PR 2657 at commit
|
jiangxb1987
reviewed
Oct 17, 2016
| def apply(baseSet: Seq[Expression]) = | ||
| new AttributeSet( | ||
| baseSet | ||
| .flatMap(_.references) |
There was a problem hiding this comment.
Perhaps we should use toAttribute instead of references for NamedExpression? Otherwise the AttributeSet.contains method may return false result. IMO we should seprate the purpose of cacheing expressions as attributes from cacheing expression.refercences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some functions that were very useful when trying to track down the bug from #2656. This change also changes the tree output for query plans to include the
'prefix to unresolved nodes and!prefix to nodes that refer to non-existent attributes.