Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-28719] [Build] Enable Github Actions for master #25440

Closed
wants to merge 2 commits into from

Conversation

dbtsai
Copy link
Member

@dbtsai dbtsai commented Aug 13, 2019

What changes were proposed in this pull request?

Github now provides free CI/CD for build, test, and deploy. This PR enables a simple Github Actions to build master with JDK8 with latest Ubuntu. We can extend it with different versions of JDK, and even build Spark with docker images in the future.

@dbtsai
Copy link
Member Author

dbtsai commented Aug 13, 2019

cc @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

I support this approach.

cc @rxin and @srowen .

@srowen
Copy link
Member

srowen commented Aug 13, 2019

I think it's worth trying. In an ideal world I think we have one CI/CD system rather than a combination Amplab Jenkins, Appveyor, and Github (we're not also on Travis right?). I support experimenting, but would rather subtract than add complexity. It might be easier long-term to get onto Github from Amplab, merely because access to the latter is quite separate from the Github permissions that committers already will have. But let's see how much Github can support the CI/CD we need. It might be a good excuse to simplify the gnarly build environment that's built up over time on Amplab.

@dbtsai
Copy link
Member Author

dbtsai commented Aug 13, 2019

What intrigues me is Github actions supports docker build, so we can use it to customize our build environment for our need. All the configuration will be in yaml file which will also give us more visibility than the current Amplab build infra.

I'm merging it now to try it out.

Thanks.

@dbtsai dbtsai closed this Aug 13, 2019
@dbtsai
Copy link
Member Author

dbtsai commented Aug 13, 2019

Okay, first build by github actions succeeded. https://github.com/apache/spark/commit/601fd458143b5f24f42c61e4645b64c6e96f3486/checks

Let's see how stable it is. At the meantime, we can extend it to run tests and add jdk11.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 13, 2019

Ya. Looks nice. Thank you, @dbtsai ! +100 for JDK11.
Screen Shot 2019-08-13 at 4 16 59 PM

@SparkQA
Copy link

SparkQA commented Aug 14, 2019

Test build #109064 has finished for PR 25440 at commit 9118cc4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

+1 for this try.

@dbtsai
Copy link
Member Author

dbtsai commented Aug 14, 2019

@HyukjinKwon Github Actions supports windows build, so we might be able to remove Appveyor.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Aug 14, 2019

That's cool if possible. I will take a look when I fine some more time.

For a quick FYI to share, actually Spark build on Windows is dependent on some environment of AppVeyor such as Cygwin (Spark build is not supported in a native Windows machine) sadly so might not be easy I guess ..

@dbtsai dbtsai deleted the actions branch November 11, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants