-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-28719] [Build] Enable Github Actions for master #25440
Conversation
I think it's worth trying. In an ideal world I think we have one CI/CD system rather than a combination Amplab Jenkins, Appveyor, and Github (we're not also on Travis right?). I support experimenting, but would rather subtract than add complexity. It might be easier long-term to get onto Github from Amplab, merely because access to the latter is quite separate from the Github permissions that committers already will have. But let's see how much Github can support the CI/CD we need. It might be a good excuse to simplify the gnarly build environment that's built up over time on Amplab. |
What intrigues me is Github actions supports docker build, so we can use it to customize our build environment for our need. All the configuration will be in yaml file which will also give us more visibility than the current Amplab build infra. I'm merging it now to try it out. Thanks. |
Okay, first build by github actions succeeded. https://github.com/apache/spark/commit/601fd458143b5f24f42c61e4645b64c6e96f3486/checks Let's see how stable it is. At the meantime, we can extend it to run tests and add jdk11. |
Ya. Looks nice. Thank you, @dbtsai ! +100 for JDK11. |
Test build #109064 has finished for PR 25440 at commit
|
+1 for this try. |
@HyukjinKwon Github Actions supports windows build, so we might be able to remove Appveyor. |
That's cool if possible. I will take a look when I fine some more time. For a quick FYI to share, actually Spark build on Windows is dependent on some environment of AppVeyor such as Cygwin (Spark build is not supported in a native Windows machine) sadly so might not be easy I guess .. |
What changes were proposed in this pull request?
Github now provides free CI/CD for build, test, and deploy. This PR enables a simple Github Actions to build master with JDK8 with latest Ubuntu. We can extend it with different versions of JDK, and even build Spark with docker images in the future.