Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-26060][SQL][FOLLOW-UP] Rename the config name. #23245

Closed
wants to merge 3 commits into from
Closed

[SPARK-26060][SQL][FOLLOW-UP] Rename the config name. #23245

wants to merge 3 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Dec 6, 2018 •
edited
Loading

What changes were proposed in this pull request?

This is a follow-up of #23031 to rename the config name to spark.sql.legacy.setCommandRejectsSparkCoreConfs.

How was this patch tested?

Existing tests.

@ueshin
Copy link
Member Author

ueshin commented Dec 6, 2018

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented Dec 6, 2018

Test build #99764 has finished for PR 23245 at commit 021134c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 6, 2018

Test build #99768 has finished for PR 23245 at commit 021134c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 7, 2018

Test build #99797 has finished for PR 23245 at commit 15000a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 7, 2018

Test build #99803 has finished for PR 23245 at commit 2e9b09c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Dec 7, 2018

Test build #99809 has finished for PR 23245 at commit 2e9b09c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@ueshin
Copy link
Member Author

ueshin commented Dec 7, 2018

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 7, 2018

Test build #99818 has finished for PR 23245 at commit 2e9b09c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@dongjoon-hyun
Copy link
Member

Thank you all. Merged to master.

@asfgit asfgit closed this in 1ab3d3e Dec 7, 2018
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@ueshin @jackylee-ch
[SPARK-26060][SQL][FOLLOW-UP] Rename the config name.
5217ec2 
## What changes were proposed in this pull request?

This is a follow-up of apache#23031 to rename the config name to `spark.sql.legacy.setCommandRejectsSparkCoreConfs`.

## How was this patch tested?

Existing tests.

Closes apache#23245 from ueshin/issues/SPARK-26060/rename_config.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

@cloud-fan cloud-fan cloud-fan approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ueshin @SparkQA @HyukjinKwon @dongjoon-hyun @cloud-fan @gatorsmile