[SPARK-24543][SQL] Support any type as DDL string for from_json's schema #21550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yea, I like this way. Did it solve your case too? |
It doesn't solve our case fully but at least it unblocks us. |
|
Test build #91759 has finished for PR 21550 at commit
|
|
retest this please |
|
Test build #91771 has finished for PR 21550 at commit
|
cloud-fan
reviewed
Jun 13, 2018
| @@ -110,6 +111,8 @@ abstract class DataType extends AbstractDataType { | |||
| @InterfaceStability.Stable | |||
| object DataType { | |||
|
|
|||
| def fromDDL(ddl: String): DataType = CatalystSqlParser.parseDataType(ddl) | |||
There was a problem hiding this comment.
I think it's reasonable for DataType.fromDDL to also support table style schema like a int, b long. How about we put the try catch here and other places just need to call DataType.fromDDL?
HyukjinKwon
approved these changes
Jun 14, 2018
|
Test build #91832 has finished for PR 21550 at commit
|
|
retest this please |
|
Test build #91844 has finished for PR 21550 at commit
|
|
thanks, merging to master! |
gatorsmile
reviewed
Jun 18, 2018
| @@ -354,8 +354,8 @@ class JsonFunctionsSuite extends QueryTest with SharedSQLContext { | |||
|
|
|||
| test("SPARK-24027: from_json - map<string, map<string, int>>") { | |||
| val in = Seq("""{"a": {"b": 1}}""").toDS() | |||
| val schema = MapType(StringType, MapType(StringType, IntegerType)) | |||
| val out = in.select(from_json($"value", schema)) | |||
| val schema = "map<string, map<string, int>>" | |||
There was a problem hiding this comment.
A general suggestion. Create a new test case for these changes, instead of modifying the existing ones.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Mar 7, 2019
## What changes were proposed in this pull request?
In the PR, I propose to support any DataType represented as DDL string for the from_json function. After the changes, it will be possible to specify `MapType` in SQL like:
```sql
select from_json('{"a":1, "b":2}', 'map<string, int>')
```
and in Scala (similar in other languages)
```scala
val in = Seq("""{"a": {"b": 1}}""").toDS()
val schema = "map<string, map<string, int>>"
val out = in.select(from_json($"value", schema, Map.empty[String, String]))
```
## How was this patch tested?
Added a couple sql tests and modified existing tests for Python and Scala. The former tests were modified because it is not imported for them in which format schema for `from_json` is provided.
Author: Maxim Gekk <maxim.gekk@databricks.com>
Closes apache#21550 from MaxGekk/from_json-ddl-schema.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Oct 15, 2019
## What changes were proposed in this pull request?
In the PR, I propose to support any DataType represented as DDL string for the from_json function. After the changes, it will be possible to specify `MapType` in SQL like:
```sql
select from_json('{"a":1, "b":2}', 'map<string, int>')
```
and in Scala (similar in other languages)
```scala
val in = Seq("""{"a": {"b": 1}}""").toDS()
val schema = "map<string, map<string, int>>"
val out = in.select(from_json($"value", schema, Map.empty[String, String]))
```
## How was this patch tested?
Added a couple sql tests and modified existing tests for Python and Scala. The former tests were modified because it is not imported for them in which format schema for `from_json` is provided.
Author: Maxim Gekk <maxim.gekk@databricks.com>
Closes apache#21550 from MaxGekk/from_json-ddl-schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to support any DataType represented as DDL string for the from_json function. After the changes, it will be possible to specify
MapTypein SQL like:and in Scala (similar in other languages)
How was this patch tested?
Added a couple sql tests and modified existing tests for Python and Scala. The former tests were modified because it is not imported for them in which format schema for
from_jsonis provided.