Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2967][SQL] Follow-up: Also copy hash expressions in sort based shuffle fix. #2072

Closed
wants to merge 1 commit into from

Conversation

marmbrus
Copy link
Contributor

Follow-up to #2066

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 2072 at commit 2ff8114.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 2072 at commit 2ff8114.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

if (sortBasedShuffleOn) {
@transient val hashExpressions =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the @transient ?

asfgit pushed a commit that referenced this pull request Aug 23, 2014
… shuffle fix.

Follow-up to #2066

Author: Michael Armbrust <michael@databricks.com>

Closes #2072 from marmbrus/sortShuffle and squashes the following commits:

2ff8114 [Michael Armbrust] Fix bug

(cherry picked from commit 3519b5e)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 3519b5e Aug 23, 2014
@marmbrus marmbrus deleted the sortShuffle branch August 27, 2014 20:56
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
… shuffle fix.

Follow-up to apache#2066

Author: Michael Armbrust <michael@databricks.com>

Closes apache#2072 from marmbrus/sortShuffle and squashes the following commits:

2ff8114 [Michael Armbrust] Fix bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants