[SPARK-21987][SQL] fix a compatibility issue of sql event logs #19237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanzin
reviewed
Sep 14, 2017
| @@ -26,6 +28,7 @@ import org.apache.spark.sql.execution.metric.SQLMetricInfo | |||
| * Stores information about a SQL SparkPlan. | |||
| */ | |||
| @DeveloperApi | |||
| @JsonIgnoreProperties(Array("metadata")) // The metadata filed was removed in Spark 2.3. | |||
| assert(reconstructedEvent == expectedEvent) | ||
| } | ||
|
|
||
| private val SQLExecutionStartJsonString = |
There was a problem hiding this comment.
Declare this inside the test since it's only used there? (Also would make it easier to match the test to the data if more tests are added.)
|
Test build #81791 has finished for PR 19237 at commit
|
|
Test build #81799 has finished for PR 19237 at commit
|
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #18600 we removed the
metadatafield fromSparkPlanInfo. This causes a problem when we replay event logs that are generated by older Spark versions.How was this patch tested?
a regression test.