Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-3006] Failed to execute spark-shell in Windows OS #1918

Closed
wants to merge 2 commits into from
Closed

[SPARK-3006] Failed to execute spark-shell in Windows OS #1918

wants to merge 2 commits into from

Conversation

tsudukim
Copy link
Contributor

Modified the order of the options and arguments in spark-shell.cmd

@tsudukim
[SPARK-3006] Failed to execute spark-shell in Windows OS
1a32410 
Modified the order of the options and arguments in spark-shell.cmd
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

Thanks @tsudukim. Windows spark-shell is currently broken and this will fix it. However, this works as a temporary solution and in the medium-long run we will need something like #1825 for Windows as well.

@andrewor14
Copy link
Contributor

test this please

andrewor14
andrewor14 reviewed Aug 13, 2014
View reviewed changes
bin/spark-shell.cmd
@@ -19,4 +19,4 @@ rem

set SPARK_HOME=%~dp0..

cmd /V /E /C %SPARK_HOME%\bin\spark-submit.cmd spark-shell --class org.apache.spark.repl.Main %*
cmd /V /E /C %SPARK_HOME%\bin\spark-submit.cmd --class org.apache.spark.repl.Main spark-shell %*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I just noticed this doesn't actually fix it all the way. You need to put %* before spark-shell as well

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA tests have started for PR 1918. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18451/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 13, 2014

QA results for PR 1918:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18451/consoleFull

@tsudukim
[SPARK-3006] Failed to execute spark-shell in Windows OS
8bba494 
re-modified the order of the arguments in order to accept submit options.
@tsudukim
Copy link
Contributor Author

Thanks @andrewor14 to follow this PR.
You're right so i modified to put %* before spark-shell. but application arguments are not available yet until we make change like #1825 .

@andrewor14
Copy link
Contributor

Doing the equivalent in #1825 is more involved and we may do that some time down the road. This is fine as is for now. LGTM.

@andrewor14
Copy link
Contributor

Thanks, merged into master and branch-1.1!

asfgit pushed a commit that referenced this pull request Aug 14, 2014
@tsudukim @andrewor14
[SPARK-3006] Failed to execute spark-shell in Windows OS
dcd99c3 
Modified the order of the options and arguments in spark-shell.cmd

Author: Masayoshi TSUZUKI <tsudukim@oss.nttdata.co.jp>

Closes #1918 from tsudukim/feature/SPARK-3006 and squashes the following commits:

8bba494 [Masayoshi TSUZUKI] [SPARK-3006] Failed to execute spark-shell in Windows OS
1a32410 [Masayoshi TSUZUKI] [SPARK-3006] Failed to execute spark-shell in Windows OS

(cherry picked from commit 9497b12)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
@asfgit asfgit closed this in 9497b12 Aug 14, 2014
@andrewor14 andrewor14 mentioned this pull request Aug 26, 2014
Closed
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@tsudukim @conviva-zz
[SPARK-3006] Failed to execute spark-shell in Windows OS
e35a057 
Modified the order of the options and arguments in spark-shell.cmd

Author: Masayoshi TSUZUKI <tsudukim@oss.nttdata.co.jp>

Closes apache#1918 from tsudukim/feature/SPARK-3006 and squashes the following commits:

8bba494 [Masayoshi TSUZUKI] [SPARK-3006] Failed to execute spark-shell in Windows OS
1a32410 [Masayoshi TSUZUKI] [SPARK-3006] Failed to execute spark-shell in Windows OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsudukim @AmplabJenkins @andrewor14 @SparkQA