[SPARK-19817][SQL] Make it clear that timeZone option is a general option in DataFrameReader/Writer.
#17281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74460 has finished for PR 17281 at commit
|
|
Test build #74461 has finished for PR 17281 at commit
|
|
Test build #74463 has finished for PR 17281 at commit
|
cloud-fan
reviewed
Mar 14, 2017
| /** | ||
| * General option(s) for the DataFrameReader and DataFrameWriter. | ||
| */ | ||
| object DataFrameReaderWriterOptions { |
There was a problem hiding this comment.
Let's remove this and always use DateTimeUtils.TIMEZONE_OPTION
|
LGTM |
gatorsmile
reviewed
Mar 14, 2017
| @@ -60,6 +60,8 @@ object DateTimeUtils { | |||
| final val TimeZoneGMT = TimeZone.getTimeZone("GMT") | |||
| final val MonthOf31Days = Set(1, 3, 5, 7, 8, 10, 12) | |||
|
|
|||
| val TIMEZONE_OPTION = "timeZone" | |||
There was a problem hiding this comment.
If we do it for timeZone, I think we should also move dateFormat and timestampFormat?
|
Test build #74547 has finished for PR 17281 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As timezone setting can also affect partition values, it works for all formats, we should make it clear.
How was this patch tested?
Existing tests.