Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14205][SQL] remove trait Queryable #12001

Closed
wants to merge 3 commits into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

After DataFrame and Dataset are merged, the trait Queryable becomes unnecessary as it has only one implementation. We should remove it.

How was this patch tested?

existing tests.

@cloud-fan
Copy link
Contributor Author

cc @liancheng @rxin @gatorsmile

@SparkQA
Copy link

SparkQA commented Mar 28, 2016

Test build #54325 has finished for PR 12001 at commit 68257a5.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 28, 2016

[error]  * the type hierarchy of class org.apache.spark.sql.Dataset is different in current version. Missing types {org.apache.spark.sql.execution.Queryable}
[error]    filter with: ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.sql.Dataset")

@rxin
Copy link
Contributor

rxin commented Mar 28, 2016

LGTM (except the mima issue).

@liancheng
Copy link
Contributor

LGTM

1 similar comment
@gatorsmile
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented Mar 28, 2016

Test build #54331 has finished for PR 12001 at commit 9bd20aa.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 28, 2016

[error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:31: object Queryable is not a member of package org.apache.spark.sql.execution
[error] import org.apache.spark.sql.execution.{LogicalRDD, Queryable}
[error]        ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:185: not found: type Queryable
[error]   def assertCached(query: Queryable, numCachedTables: Int = 1): Unit = {
[error]                           ^
[error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:291: not found: type Queryable
[error]   def assertEmptyMissingInput(query: Queryable): Unit = {
[error]                                      ^

@SparkQA
Copy link

SparkQA commented Mar 29, 2016

Test build #54382 has finished for PR 12001 at commit 9d0497f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Mar 29, 2016

Thanks - merging in master.

@asfgit asfgit closed this in 38326ca Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants