-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-13660][SQL][Tests] ContinuousQuerySuite floods the logs with garbage #11703
Conversation
ok to test |
Test build #53111 has finished for PR 11703 at commit
|
Test build #53125 has finished for PR 11703 at commit
|
Test build #53126 has finished for PR 11703 at commit
|
Hi, @keypointt . |
@dongjoon-hyun I think it's just missing some exclude claims? I had similar issues before, and what I did before was adding those ones to exclude claims |
Sure, you're right. If the claims are correct, you did the right things. I meant the MiMa status is strange now. :) |
I've just now tested on my local machine by "./dev/mima" and it passed testing. Let's see what happens on Jenkins. |
Could you try again './dev/mima' with only the first commit locally? By the way, I'm not a Spark committer, too. |
Oh I tried './dev/mima' on my first commit, and it failed both locally and on Jenkins, that's why I started modifying the mima file |
@zsxwing I just had a quick look on Jenkins, and all the recent PRs are failed by this MiMa test, could you please have a look at my changes to make sure I'm doing it right? |
I think your fix is correct. Let's see if it passes all tests |
Let's not attempt to fix the MIMA issues in this patch; SPARK-13660 has nothing to do with MIMA. |
Test build #53131 has finished for PR 11703 at commit
|
@@ -319,6 +319,68 @@ object MimaExcludes { | |||
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.predictions"), | |||
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.predictions") | |||
) ++ Seq( | |||
// [SPARK-13660][SQL][Tests] ContinuousQuerySuite floods the logs with garbage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you undo all the mima changes? there was a problem with the build and we fixed that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I'll undo it
Thanks - merging in master. |
Test build #53168 has finished for PR 11703 at commit
|
Thanks a lot 👍 |
…arbage ## What changes were proposed in this pull request? Use method 'testQuietly' to avoid ContinuousQuerySuite flooding the console logs with garbage Make ContinuousQuerySuite not output logs to the console. The logs will still output to unit-tests.log. ## How was this patch tested? Just check Jenkins output. Author: Xin Ren <iamshrek@126.com> Closes apache#11703 from keypointt/SPARK-13660.
What changes were proposed in this pull request?
Use method 'testQuietly' to avoid ContinuousQuerySuite flooding the console logs with garbage
Make ContinuousQuerySuite not output logs to the console. The logs will still output to unit-tests.log.
How was this patch tested?
Just check Jenkins output.