[SPARK-13459] [Web UI] Separate Alive and Dead Executors in Executor Totals Table #11381
Conversation
|
New Look: Current Look: |
| @@ -86,7 +86,7 @@ private[ui] class ExecutorsPage( | |||
| <th>Failed Tasks</th> | |||
| <th>Complete Tasks</th> | |||
| <th>Total Tasks</th> | |||
| <th data-toggle="tooltip" title={ToolTips.TASK_TIME}>Task Time (GC Time)</th> | |||
| <th><span data-toggle="tooltip" title={ToolTips.TASK_TIME}>Task Time (GC Time)</span></th> | |||
There was a problem hiding this comment.
Fixed this to match other tooltips. This originally was added in a related task.
|
@tgravescs This is a follow up to #10668 |
|
Test build #52008 has finished for PR 11381 at commit
|
|
I'll try to look at this early next week. ping me again if I forget. |
|
Jenkins, retest this please |
|
Test build #52086 has finished for PR 11381 at commit
|
|
@tgravescs reminding you as you requested |
|
trying it out today |
|
this looks good. The only thing is now I think it makes more sense to just put the # of executors in its own column rather then in () by the "Active"/"Dead"/"Total" |
|
I had originally done that but it just felt off to me, I've recreated the different options, I'll commit whichever looks best to you (the second one is my favorite) |
|
Ah, I see what you mean, the extra column header can make that a pretty big column. Ok lets leave it as is for now. We can always change it later if people are confused. LGTM, thanks! |
…otals Table ## What changes were proposed in this pull request? Now that dead executors are shown in the executors table (apache#10058) the totals table is updated to include the separate totals for alive and dead executors as well as the current total, as originally discussed in apache#10668 ## How was this patch tested? Manually verified by running the Standalone Web UI in the latest Safari and Firefox ESR Author: Alex Bozarth <ajbozart@us.ibm.com> Closes apache#11381 from ajbozarth/spark13459.
What changes were proposed in this pull request?
Now that dead executors are shown in the executors table (#10058) the totals table is updated to include the separate totals for alive and dead executors as well as the current total, as originally discussed in #10668
How was this patch tested?
Manually verified by running the Standalone Web UI in the latest Safari and Firefox ESR