-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] Add average overflow test case from #978 #1033
Conversation
Merged build triggered. |
Merged build triggered. |
Merged build started. |
1 similar comment
Merged build started. |
Merged build finished. |
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15613/ |
ok, hope that helpful. |
Merged build finished. All automated tests passed. |
All automated tests passed. |
By @egraldlo. Author: egraldlo <egraldlo@gmail.com> Author: Michael Armbrust <michael@databricks.com> Closes #1033 from marmbrus/pr/978 and squashes the following commits: e228c5e [Michael Armbrust] Remove "test". 762aeaf [Michael Armbrust] Remove unneeded rule. More descriptive name for test table. d414cd7 [egraldlo] fommatting issues 1153f75 [egraldlo] do best to avoid overflowing in function avg(). (cherry picked from commit 1abbde0) Signed-off-by: Michael Armbrust <michael@databricks.com>
Merged into master and 1.0 |
By @egraldlo. Author: egraldlo <egraldlo@gmail.com> Author: Michael Armbrust <michael@databricks.com> Closes apache#1033 from marmbrus/pr/978 and squashes the following commits: e228c5e [Michael Armbrust] Remove "test". 762aeaf [Michael Armbrust] Remove unneeded rule. More descriptive name for test table. d414cd7 [egraldlo] fommatting issues 1153f75 [egraldlo] do best to avoid overflowing in function avg().
By @egraldlo. Author: egraldlo <egraldlo@gmail.com> Author: Michael Armbrust <michael@databricks.com> Closes apache#1033 from marmbrus/pr/978 and squashes the following commits: e228c5e [Michael Armbrust] Remove "test". 762aeaf [Michael Armbrust] Remove unneeded rule. More descriptive name for test table. d414cd7 [egraldlo] fommatting issues 1153f75 [egraldlo] do best to avoid overflowing in function avg().
… if its child max rows not larger than limit number (#1033) * [SPARK-34628][SQL] Remove GlobalLimit operator if its child max rows not larger than limit number ### What changes were proposed in this pull request? This pr remove `GlobalLimit` operator if its child max rows not larger than limit number. For example: ``` val testRelation = LocalRelation.fromExternalRows(Seq("a".attr.int, "b".attr.int, "c".attr.int), 1.to(10).map(_ => Row(1, 2, 3)) ) val query = GlobalLimit(100, testRelation) ``` We can remove this `GlobalLimit`. ### Why are the changes needed? Further optimize the query. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. Closes #31750 from wangyum/SPARK-34628. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
By @egraldlo.