remove default implementation of Table.name

apache · Nov 30, 2018 · eecb161 · eecb161
1 parent 811481a
commit eecb161
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java b/sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
@@ -37,16 +37,10 @@
 public interface Table {
 
   /**
-   * A name to identify this table.
-   * <p>
-   * By default this returns the class name of the implementation. Please override it to provide a
-   * meaningful name, like the database and table name from catalog, or the location of files for
-   * this table.
-   * </p>
+   * A name to identify this table. Implementations should provide a meaningful name, like the
+   * database and table name from catalog, or the location of files for this table.
    */
-  default String name() {
-    return this.getClass().toString();
-  }
+  String name();
 
   /**
    * Returns the schema of this table.

diff --git a/sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleBatchTable.java b/sql/core/src/test/java/test/org/apache/spark/sql/sources/v2/JavaSimpleBatchTable.java
@@ -32,6 +32,11 @@ abstract class JavaSimpleBatchTable implements Table, SupportsBatchRead {
   public StructType schema() {
     return new StructType().add("i", "int").add("j", "int");
   }
+
+  @Override
+  public String name() {
+    return this.getClass().toString();
+  }
 }
 
 abstract class JavaSimpleScanBuilder implements ScanBuilder, Scan, Batch {

diff --git a/sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala b/sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
@@ -394,6 +394,8 @@ object SimpleReaderFactory extends PartitionReaderFactory {
 abstract class SimpleBatchTable extends Table with SupportsBatchRead  {
 
   override def schema(): StructType = new StructType().add("i", "int").add("j", "int")
+
+  override def name(): String = this.getClass.toString
 }
 
 abstract class SimpleScanBuilder extends ScanBuilder