code improve

apache · Sep 3, 2014 · d7315b3 · d7315b3
1 parent eed35fc
commit d7315b3
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
@@ -265,11 +265,7 @@ case class CaseWhen(branches: Seq[Expression]) extends Expression {
       false
     } else {
       val allCondBooleans = predicates.forall(_.dataType == BooleanType)
-      val valueTypes = branches.sliding(2, 2).map {
-        case Seq(_, value) => value.dataType
-        case Seq(elseVal) => elseVal.dataType
-      }.toSeq
-      val dataTypesEqual = valueTypes.distinct.size <= 1
+      val dataTypesEqual = (values ++ elseValue).map(_.dataType).distinct.size <= 1
       allCondBooleans && dataTypesEqual
     }
   }